coverage: Tidy up creation of covmap and covfun records #134208

Zalathar · 2024-12-12T11:29:48Z

This is a small follow-up to #134163 that mostly just inlines and renames some variables, and adds a few comments.

It also slightly defers the creation of the LLVM value that holds the filename table, to just before the value is needed.

try-job: x86_64-mingw-2
try-job: dist-x86_64-linux

rustbot · 2024-12-12T11:29:57Z

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler-errors · 2024-12-12T14:24:49Z

@bors r+

bors · 2024-12-12T14:24:52Z

📌 Commit 5f5745b has been approved by compiler-errors

It is now in the queue for this repository.

compiler-errors · 2024-12-13T00:41:38Z

@bors rollup

…-errors coverage: Tidy up creation of covmap and covfun records This is a small follow-up to rust-lang#134163 that mostly just inlines and renames some variables, and adds a few comments. It also slightly defers the creation of the LLVM value that holds the filename table, to just before the value is needed.

…mpiler-errors Rollup of 10 pull requests Successful merges: - rust-lang#130060 (Autodiff Upstreaming - rustc_codegen_llvm changes) - rust-lang#132150 (Fix powerpc64 big-endian FreeBSD ABI) - rust-lang#133942 (Clarify how to use `black_box()`) - rust-lang#134081 (Try to evaluate constants in legacy mangling) - rust-lang#134192 (Remove `Lexer`'s dependency on `Parser`.) - rust-lang#134208 (coverage: Tidy up creation of covmap and covfun records) - rust-lang#134209 (validate `--skip` and `--exclude` paths) - rust-lang#134211 (On Neutrino QNX, reduce the need to set archiver via environment variables) - rust-lang#134227 (Update wasi-sdk used to build WASI targets) - rust-lang#134229 (Fix typos in docs on provenance) r? `@ghost` `@rustbot` modify labels: rollup

compiler-errors · 2024-12-13T03:50:01Z

@bors r- rollup-

failed in a rollup: #134239 (comment)

Zalathar · 2024-12-13T04:08:57Z

From the error message, I think the failure was actually due to #134209, and this PR is unrelated.

I'll run a try job on this PR; if it succeeds I'll re-queue.

@bors try

coverage: Tidy up creation of covmap and covfun records This is a small follow-up to rust-lang#134163 that mostly just inlines and renames some variables, and adds a few comments. It also slightly defers the creation of the LLVM value that holds the filename table, to just before the value is needed. --- try-job: x86_64-mingw-2

bors · 2024-12-13T04:10:08Z

⌛ Trying commit 5f5745b with merge 742b4df...

compiler-errors · 2024-12-13T04:10:40Z

you're almost certainly right--I just saw covmap and pattern matched too hard 😺

bors · 2024-12-13T06:29:37Z

☀️ Try build successful - checks-actions
Build commit: 742b4df (742b4df4924d4ec16ef2c43f4af38f586b4641d9)

Zalathar · 2024-12-13T06:34:40Z

@bors r=compiler-errors rollup

bors · 2024-12-13T06:34:43Z

📌 Commit 5f5745b has been approved by compiler-errors

It is now in the queue for this repository.

…-errors coverage: Tidy up creation of covmap and covfun records This is a small follow-up to rust-lang#134163 that mostly just inlines and renames some variables, and adds a few comments. It also slightly defers the creation of the LLVM value that holds the filename table, to just before the value is needed. --- try-job: x86_64-mingw-2

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#132038 (Add lint rule for `#[deprecated]` on re-exports) - rust-lang#132150 (Fix powerpc64 big-endian FreeBSD ABI) - rust-lang#133633 (don't show the full linker args unless `--verbose` is passed) - rust-lang#133942 (Clarify how to use `black_box()`) - rust-lang#134081 (Try to evaluate constants in legacy mangling) - rust-lang#134192 (Remove `Lexer`'s dependency on `Parser`.) - rust-lang#134208 (coverage: Tidy up creation of covmap and covfun records) - rust-lang#134211 (On Neutrino QNX, reduce the need to set archiver via environment variables) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-12-13T12:17:29Z

@bors try

maybe failed in #134249 (comment)

bors · 2024-12-13T12:17:31Z

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

matthiaskrgr · 2024-12-13T12:33:23Z

@bors r-

matthiaskrgr · 2024-12-13T12:33:29Z

@bors try

coverage: Tidy up creation of covmap and covfun records This is a small follow-up to rust-lang#134163 that mostly just inlines and renames some variables, and adds a few comments. It also slightly defers the creation of the LLVM value that holds the filename table, to just before the value is needed. --- try-job: x86_64-mingw-2 try-job: dist-x86_64-linux

bors · 2024-12-13T12:34:39Z

⌛ Trying commit 5f5745b with merge fe63eb0...

Zalathar · 2024-12-13T12:50:49Z

Seems unrelated, but I guess we'll see from the outcome of the try build.

bors · 2024-12-13T14:55:14Z

☀️ Try build successful - checks-actions
Build commit: fe63eb0 (fe63eb01d49c13968e8f45db27d3afd4722bb6de)

matthiaskrgr · 2024-12-13T15:37:25Z

@bors r=compiler-errors rollup

bors · 2024-12-13T15:37:27Z

📌 Commit 5f5745b has been approved by compiler-errors

It is now in the queue for this repository.

…-errors coverage: Tidy up creation of covmap and covfun records This is a small follow-up to rust-lang#134163 that mostly just inlines and renames some variables, and adds a few comments. It also slightly defers the creation of the LLVM value that holds the filename table, to just before the value is needed. --- try-job: x86_64-mingw-2 try-job: dist-x86_64-linux

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#132150 (Fix powerpc64 big-endian FreeBSD ABI) - rust-lang#133633 (don't show the full linker args unless `--verbose` is passed) - rust-lang#133942 (Clarify how to use `black_box()`) - rust-lang#134081 (Try to evaluate constants in legacy mangling) - rust-lang#134192 (Remove `Lexer`'s dependency on `Parser`.) - rust-lang#134208 (coverage: Tidy up creation of covmap and covfun records) - rust-lang#134211 (On Neutrino QNX, reduce the need to set archiver via environment variables) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#132150 (Fix powerpc64 big-endian FreeBSD ABI) - rust-lang#133942 (Clarify how to use `black_box()`) - rust-lang#134081 (Try to evaluate constants in legacy mangling) - rust-lang#134192 (Remove `Lexer`'s dependency on `Parser`.) - rust-lang#134208 (coverage: Tidy up creation of covmap and covfun records) - rust-lang#134211 (On Neutrino QNX, reduce the need to set archiver via environment variables) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#134208 - Zalathar:covmap-covfun, r=compiler-errors coverage: Tidy up creation of covmap and covfun records This is a small follow-up to rust-lang#134163 that mostly just inlines and renames some variables, and adds a few comments. It also slightly defers the creation of the LLVM value that holds the filename table, to just before the value is needed. --- try-job: x86_64-mingw-2 try-job: dist-x86_64-linux

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#132150 (Fix powerpc64 big-endian FreeBSD ABI) - rust-lang#133942 (Clarify how to use `black_box()`) - rust-lang#134081 (Try to evaluate constants in legacy mangling) - rust-lang#134192 (Remove `Lexer`'s dependency on `Parser`.) - rust-lang#134208 (coverage: Tidy up creation of covmap and covfun records) - rust-lang#134211 (On Neutrino QNX, reduce the need to set archiver via environment variables) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar added 2 commits December 12, 2024 22:10

coverage: Tidy up creation of covmap records

de53fe2

coverage: Tidy up creation of covfun records

5f5745b

Zalathar added the A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) label Dec 12, 2024

rustbot assigned compiler-errors Dec 12, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 12, 2024

jieyouxu mentioned this pull request Dec 12, 2024

coverage: Rearrange the code for embedding per-function coverage metadata #134163

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2024

compiler-errors mentioned this pull request Dec 13, 2024

Rollup of 10 pull requests #134239

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 13, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2024

Zalathar mentioned this pull request Dec 13, 2024

Rollup of 9 pull requests #134245

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 13, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2024

matthiaskrgr mentioned this pull request Dec 13, 2024

Rollup of 8 pull requests #134280

Closed

matthiaskrgr mentioned this pull request Dec 13, 2024

Rollup of 7 pull requests #134282

Closed

Zalathar mentioned this pull request Dec 14, 2024

Rollup of 10 pull requests #134289

Closed

matthiaskrgr mentioned this pull request Dec 14, 2024

Rollup of 6 pull requests #134296

Merged

bors merged commit 704102c into rust-lang:master Dec 14, 2024
7 checks passed

rustbot added this to the 1.85.0 milestone Dec 14, 2024

Zalathar deleted the covmap-covfun branch December 15, 2024 00:08

coverage: Tidy up creation of covmap and covfun records #134208

coverage: Tidy up creation of covmap and covfun records #134208

Uh oh!

Conversation

Zalathar commented Dec 12, 2024 • edited by matthiaskrgr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 12, 2024

Uh oh!

compiler-errors commented Dec 12, 2024

Uh oh!

bors commented Dec 12, 2024

Uh oh!

compiler-errors commented Dec 13, 2024

Uh oh!

compiler-errors commented Dec 13, 2024

Uh oh!

Zalathar commented Dec 13, 2024

Uh oh!

bors commented Dec 13, 2024

Uh oh!

compiler-errors commented Dec 13, 2024

Uh oh!

bors commented Dec 13, 2024

Uh oh!

Zalathar commented Dec 13, 2024

Uh oh!

bors commented Dec 13, 2024

Uh oh!

matthiaskrgr commented Dec 13, 2024

Uh oh!

bors commented Dec 13, 2024

Uh oh!

matthiaskrgr commented Dec 13, 2024

Uh oh!

matthiaskrgr commented Dec 13, 2024

Uh oh!

bors commented Dec 13, 2024

Uh oh!

Zalathar commented Dec 13, 2024

Uh oh!

bors commented Dec 13, 2024

Uh oh!

matthiaskrgr commented Dec 13, 2024

Uh oh!

bors commented Dec 13, 2024

Uh oh!

Uh oh!

Uh oh!

Zalathar commented Dec 12, 2024 •

edited by matthiaskrgr

Loading